From fe5d88996822d8ecc4ea544e0d2f50d1f3afdeca Mon Sep 17 00:00:00 2001
From: Jannis Pohlmann <jannis@edgeandnode.com>
Date: Wed, 11 Oct 2023 22:58:03 +0200
Subject: [PATCH] refactor: reduce cost model test code

---
 service/src/common/indexer_management/mod.rs | 33 ++++++--------------
 1 file changed, 10 insertions(+), 23 deletions(-)

diff --git a/service/src/common/indexer_management/mod.rs b/service/src/common/indexer_management/mod.rs
index 3fd6708c..32a19e12 100644
--- a/service/src/common/indexer_management/mod.rs
+++ b/service/src/common/indexer_management/mod.rs
@@ -218,15 +218,14 @@ mod test {
         .expect("Create test instance in db");
     }
 
-    async fn add_cost_models(pool: &PgPool, models: Vec<CostModel>) {
+    async fn add_cost_models(pool: &PgPool, models: Vec<DbCostModel>) {
         for model in models {
-            let deployment = model.deployment;
             sqlx::query!(
                 r#"
                 INSERT INTO "CostModels" (deployment, model)
                 VALUES ($1, $2);
                 "#,
-                format!("{deployment:#x}"),
+                model.deployment,
                 model.model,
             )
             .execute(pool)
@@ -235,20 +234,8 @@ mod test {
         }
     }
 
-    async fn add_db_cost_models(pool: &PgPool, models: Vec<DbCostModel>) {
-        for model in models {
-            sqlx::query!(
-                r#"
-                INSERT INTO "CostModels" (deployment, model)
-                VALUES ($1, $2);
-                "#,
-                model.deployment,
-                model.model,
-            )
-            .execute(pool)
-            .await
-            .expect("Create test instance in db");
-        }
+    fn to_db_models(models: Vec<CostModel>) -> Vec<DbCostModel> {
+        models.into_iter().map(DbCostModel::from).collect()
     }
 
     fn global_cost_model() -> DbCostModel {
@@ -294,7 +281,7 @@ mod test {
             .collect::<HashSet<_>>();
 
         setup_cost_models_table(&pool).await;
-        add_cost_models(&pool, test_models.clone()).await;
+        add_cost_models(&pool, to_db_models(test_models.clone())).await;
 
         // First test: query without deployment filter
         let models = cost_models(&pool, &[])
@@ -358,8 +345,8 @@ mod test {
         let global_model = global_cost_model();
 
         setup_cost_models_table(&pool).await;
-        add_cost_models(&pool, test_models.clone()).await;
-        add_db_cost_models(&pool, vec![global_model.clone()]).await;
+        add_cost_models(&pool, to_db_models(test_models.clone())).await;
+        add_cost_models(&pool, vec![global_model.clone()]).await;
 
         // First test: fetch cost models without filtering by deployment
         let models = cost_models(&pool, &[])
@@ -443,7 +430,7 @@ mod test {
     #[sqlx::test]
     async fn success_cost_model(pool: PgPool) {
         setup_cost_models_table(&pool).await;
-        add_cost_models(&pool, test_data()).await;
+        add_cost_models(&pool, to_db_models(test_data())).await;
 
         let deployment_id_from_bytes = DeploymentId(
             "0xbd499f7673ca32ef4a642207a8bebdd0fb03888cf2678b298438e3a1ae5206ea"
@@ -470,8 +457,8 @@ mod test {
         let global_model = global_cost_model();
 
         setup_cost_models_table(&pool).await;
-        add_cost_models(&pool, test_models.clone()).await;
-        add_db_cost_models(&pool, vec![global_model.clone()]).await;
+        add_cost_models(&pool, to_db_models(test_models.clone())).await;
+        add_cost_models(&pool, vec![global_model.clone()]).await;
 
         // Test that the behavior is correct for existing deployments
         for test_model in test_models {