From 43f1a1c42efa59e08cf809d0b2e3fa06441984e8 Mon Sep 17 00:00:00 2001 From: hopeyen Date: Fri, 29 Sep 2023 08:57:45 -0700 Subject: [PATCH] fix: remove name label from QUERY_DURATION metrics --- service/src/metrics/mod.rs | 3 +-- service/src/server/routes/status.rs | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/service/src/metrics/mod.rs b/service/src/metrics/mod.rs index f98789394..74737197e 100644 --- a/service/src/metrics/mod.rs +++ b/service/src/metrics/mod.rs @@ -80,7 +80,6 @@ pub static QUERIES_WITHOUT_RECEIPT: Lazy = Lazy::new(|| { m }); -#[allow(dead_code)] pub static QUERY_DURATION: Lazy = Lazy::new(|| { let m = HistogramVec::new( HistogramOpts::new( @@ -90,7 +89,7 @@ pub static QUERY_DURATION: Lazy = Lazy::new(|| { .namespace("indexer") .subsystem("service") .buckets(linear_buckets(0.0, 1.0, 20).unwrap()), - &["deployment", "name"], + &["deployment"], ) .expect("Failed to create query_duration histograms"); prometheus::register(Box::new(m.clone())).expect("Failed to register query_duration counter"); diff --git a/service/src/server/routes/status.rs b/service/src/server/routes/status.rs index 65a0eba78..349370663 100644 --- a/service/src/server/routes/status.rs +++ b/service/src/server/routes/status.rs @@ -43,7 +43,7 @@ pub async fn status_queries( // Read the requested query string let query_string = match String::from_utf8(body_bytes.to_vec()) { Ok(s) => s, - Err(e) => return bad_request_response(&e.to_string()), + Err(e) => bad_request_response(&e.to_string()), }; // filter supported root fields