Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from ethabi to alloy #5692

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Migrate from ethabi to alloy #5692

wants to merge 2 commits into from

Conversation

isum
Copy link
Member

@isum isum commented Oct 30, 2024 •
edited
Loading

This PR removes the deprecated ethabi dependency and migrates the codebase to alloy.

Closes #5669

⚠️ Requires attention:

The ethabi::Token enum has fewer variants than alloy_dyn_abi::DynSolValue, so the EthereumValueKind enum was extended to support function pointer kind.

Todos

  • Make sure all tests pass
  • Make sure that the existing functionality has not been changed in any way

@isum isum added the dependencies Pull requests that update a dependency file label Oct 30, 2024
@isum isum self-assigned this Oct 30, 2024
@isum isum force-pushed the ion/migrate-to-alloy-rs branch from a237082 to 9e19b0d Compare November 1, 2024 12:18
@isum isum force-pushed the ion/migrate-to-alloy-rs branch from 9e19b0d to a6a1cbf Compare November 4, 2024 15:27
@isum isum marked this pull request as ready for review November 4, 2024 15:41
@fordN fordN requested a review from mangas November 4, 2024 16:47
mangas
mangas approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@mangas mangas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see commends about testing otherwise LGTM

@mangas
Copy link
Contributor

mangas commented Nov 6, 2024

We absolutely need to test this on the integration cluster before merging though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mangas mangas mangas approved these changes

Assignees

@isum isum

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No longer rely on deprecated ethabi crate
2 participants
@isum @mangas