Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: master document containing a log of the TODO comments found in the project files #1033

Open
MoonBoi9001 opened this issue Sep 18, 2024 · 0 comments

Comments

@MoonBoi9001
Copy link
Member

MoonBoi9001 commented Sep 18, 2024

While reviewing the OZ audit N-04 I found advice to document TODO comments inside our project issues backlog.

I found the following TODO's at commit 4387c6cdc7cf437e75b46d3af3f1d88aa1fdb925

The following TODO's are on .sol files.

  • Line 19 of packages\horizon\contracts\interfaces\internal\IHorizonStakingBase.sol
  • Line 44 of packages\horizon\contracts\interfaces\internal\IHorizonStakingExtension.sol
  • Line 5 of packages\horizon\contracts\interfaces\internal\IHorizonStakingTypes.sol
  • Lines 44, 390, 558, 717, 766 of packages\horizon\contracts\staking\HorizonStaking.sol
  • Lines 242, 257 of packages\horizon\contracts\staking\HorizonStakingBase.sol
  • Lines 25, 92, 105, 119, 219, 229, 240, 254, 310 of packages\horizon\contracts\staking\HorizonStakingExtension.sol
  • Line 11 of packages\horizon\contracts\staking\HorizonStakingStorage.sol
  • Line 7 of packages\horizon\contracts\staking\utilities\Managed.sol
  • Line 59 of packages\horizon\contracts\utilities\GraphDirectory.sol
  • Line 64 of packages\horizon\test\staking\delegation\addToPool.t.sol
  • Line 104 of packages\subgraph-service\test\shared\SubgraphServiceShared.t.sol
  • Line 255 of packages\subgraph-service\test\subgraphService\SubgraphService.t.sol
  • Lines 34, 75 of packages\subgraph-service\test\subgraphService\collect\indexing\indexing.t.sol

The following TODO's are on other files (not .sol).

  • Lines 2, 3, 5, 6, 7 of packages\contracts\config\graph.arbitrum-goerli.yml
  • Lines 2, 3 of packages\contracts\config\graph.arbitrum-sepolia.yml
  • Line 15 of packages\contracts\tasks\migrate\protocol.ts
  • Line 39 of packages\contracts\test\e2e\deployment\config\l2\l2GraphTokenGateway.test.ts
  • Line 9 of packages\contracts\test\e2e\upgrades\exponential-rebates\post-upgrade.ts
  • Line 80 of packages\contracts\test\unit\lib\gnsUtils.ts
  • Lines 14, 15 of packages\sdk\.eslintrc
  • Line 123 of packages\sdk\src\deployments\lib\address-book.ts
  • Line 14 of packages\sdk\src\deployments\lib\config.ts
  • Line 3 of packages\sdk\src\deployments\lib\types\address-book.ts
  • Line 16 of packages\sdk\src\deployments\network\deployment\address-book.ts
  • Lines 101, 117 of packages\sdk\src\deployments\network\deployment\config.ts
  • Lines 164, 276, 283, 292 of packages\sdk\src\deployments\network\deployment\contracts\deploy.ts
  • Line 238 of packages\sdk\src\gre\README.md
  • Line 58 of packages\token-distribution\deploy\4_l1_transfer_tool.ts
  • Line 46 of packages\token-distribution\deploy\6_l2_transfer_tool.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant