Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic during recovery #273

Open
nazar-pc opened this issue Dec 6, 2024 · 0 comments
Open

Panic during recovery #273

nazar-pc opened this issue Dec 6, 2024 · 0 comments

Comments

@nazar-pc
Copy link
Contributor

nazar-pc commented Dec 6, 2024

I do not have exact inputs, but overall the number of panics I was getting from this library is concerning, there is too many .unwrap()s without proofs.

Here is one that user caught:

Dec 06 07:10:36 alpha bash[111042]: thread 'tokio-runtime-worker' panicked at /root/.cargo/git/checkouts/rust-kzg-b3b2ba43d312a1eb/6c8fcc6/blst/src/recovery.rs:106:79:
Dec 06 07:10:36 alpha bash[111042]: called `Result::unwrap()` on an `Err` value: "A list with power-of-two length expected"

Consider replacing countless .unwrap() with .expect() that have proofs and add fuzzing to catch panics like this.

@nazar-pc nazar-pc changed the title Panic during recovery: Panic during recovery Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant