Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grails 3.3.x Support #161

Closed
robertoschwald opened this issue Feb 3, 2018 · 9 comments
Closed

Grails 3.3.x Support #161

robertoschwald opened this issue Feb 3, 2018 · 9 comments
Assignees
Labels
Milestone

Comments

@robertoschwald
Copy link
Contributor

robertoschwald commented Feb 3, 2018

  • Rewrite plugin to use CompileStatic where possible
  • Use Traits instead of AST Transformations
  • Cleanup code
  • Remove Handler support (users can use the GORM events directly in their Domain classes)
@robertoschwald robertoschwald added this to the 3.3.0 milestone Feb 3, 2018
robertoschwald added a commit that referenced this issue Feb 3, 2018
robertoschwald added a commit that referenced this issue Feb 15, 2018
@sudosandwich3
Copy link

Hey, What still needs to be done to upgrade the plugin to 3.3.x? Is there a road map, or any opportunities to submit PRs?

@robertoschwald
Copy link
Contributor Author

I think the GORM Api has changed. Didn't have time to look at it. PR welcome.

@longwa
Copy link
Contributor

longwa commented Jul 27, 2018

@robertoschwald The changes I made already support 3.3.x and we are using it today with 3.3.6 and GORM 6.1.10.

I think we just need to officially release my Trait rewrite.

@longwa
Copy link
Contributor

longwa commented Jul 27, 2018

@sudosandwich3 Take a look at the docs at https://robertoschwald.github.io/grails-audit-logging-plugin/snapshot/plugin.html.

The current master branch is 3.0.0-SNAPSHOT and is a large rewrite of the API but works with Grails 3.3.x. The migration isn't too difficult and the docs should explain the main changes.

I would also like to see the official 3.0.0 version released.

@longwa
Copy link
Contributor

longwa commented Jul 27, 2018

Crap, looks like the documentation formatting has gotten messed up at some point along the way. I'll try to push a change to clean it up.

@robertoschwald
Copy link
Contributor Author

@longwa Goodto know it works with 3.3.6 as well. I will bake a release then.

@longwa
Copy link
Contributor

longwa commented Jul 27, 2018

@robertoschwald I pushed a change to fix the documentation formatting issue and remove the references to the Stamp support (I think Dennie pulled that stuff into a separate plugin). I'm not sure how you were publishing the docs but if you pull now and regenerate it should be good.

@robertoschwald
Copy link
Contributor Author

Thanks for the change. Plugin is still supporting Stampable. Dennie has started PR #167 which is not finished, yet. I revert the doc files for Stampable refs.

@robertoschwald
Copy link
Contributor Author

Need to migrate gradle build file for grailsPublish plugin, also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants