Inline TempoComponentSpec struct in spec.template.

[andreasgerstmayr]

Currently the rendered version of a TempoStack looks like this:

template:
  compactor:
    replicas: 1
  distributor:
    component:
      replicas: 1
  ingester:
    replicas: 2
  querier:
    replicas: 1
  queryFrontend:
    component:
      replicas: 1

Where replicas is directly under the component for compactor, ingester and querier, but not for distributor and queryFrontend.

In the code at

tempo-operator/apis/tempo/v1alpha1/tempostack_types.go

Lines 521 to 522 in 5a79e61

	// Currently, there is no way to inline this field.
	// See: https://github.com/golang/go/issues/6213

is a link to golang/go#6213, but I don't follow, afaics the following works fine:

type TempoDistributorSpec struct {
    TempoComponentSpec `json:",inline"`
}

and is already used at another place:

type TempoStack struct {
	metav1.TypeMeta   `json:",inline"`
}

Is there a corner case I'm missing here? Or did this feature get implemented in the meantime?