Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: resources.limits in small.yaml for Helm produce warnings - values should be quoted #10307

Open
Jeansen opened this issue Dec 23, 2024 · 0 comments
Labels
bug Something isn't working helm

Comments

@Jeansen
Copy link

Jeansen commented Dec 23, 2024

What is the bug?

Using https://github.com/grafana/mimir/blob/main/operations/helm/charts/mimir-distributed/small.yaml when installing via Helm gives the following warnings:

W1223 21:38:18.060748 1501775 warnings.go:70] spec.template.spec.containers[0].resources.limits[memory]: fractional byte value "3006477107200m" is invalid, must be an integer
W1223 21:38:18.076453 1501775 warnings.go:70] spec.template.spec.containers[0].resources.limits[memory]: fractional byte value "6012954214400m" is invalid, must be an integer
W1223 21:38:18.080387 1501775 warnings.go:70] spec.template.spec.containers[0].resources.limits[memory]: fractional byte value "3006477107200m" is invalid, must be an integer
W1223 21:38:18.080536 1501775 warnings.go:70] spec.template.spec.containers[0].resources.limits[memory]: fractional byte value "6120328396800m" is invalid, must be an integer
W1223 21:38:18.207262 1501775 warnings.go:70] spec.template.spec.containers[0].resources.limits[memory]: fractional byte value "2254857830400m" is invalid, must be an integer
W1223 21:38:18.207500 1501775 warnings.go:70] spec.template.spec.containers[0].resources.limits[memory]: fractional byte value "2254857830400m" is invalid, must be an integer
W1223 21:38:18.207660 1501775 warnings.go:70] spec.template.spec.containers[0].resources.limits[memory]: fractional byte value "2254857830400m" is invalid, must be an integer
W1223 21:38:18.213446 1501775 warnings.go:70] spec.template.spec.containers[0].resources.limits[memory]: fractional byte value "1503238553600m" is invalid, must be an integer
W1223 21:38:18.215864 1501775 warnings.go:70] spec.template.spec.containers[0].resources.limits[memory]: fractional byte value "2254857830400m" is invalid, must be an integer

How to reproduce it?

helm install mimir-prod grafana/mimir-distributed -f https://github.com/grafana/mimir/blob/main/operations/helm/charts/mimir-distributed/small.yaml

What did you think would happen?

A clean install without warnings or errors.

What was your environment?

Kubernetes:

Client Version: v1.31.4
Kustomize Version: v5.4.2
Server Version: v1.32.0

Helm:

version.BuildInfo{Version:"v3.16.3", GitCommit:"cfd07493f46efc9debd9cc1b02a0961186df7fdf", GitTreeState:"clean", GoVersion:"go1.22.7"}

Any additional context to share?

The fix is quite easy. All values for resoruces limits and requests need to be quoted, e.g:

alertmanager:
  persistentVolume:
    enabled: true
  replicas: 2
  resources:
    limits:
      memory: "1.4Gi"
    requests:
      cpu: "1"
      memory: "1Gi"
  statefulSet:
    enabled: true

See: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#example-2

I'd be happy to create a PR with correct values.

@Jeansen Jeansen added the bug Something isn't working label Dec 23, 2024
@narqo narqo added the helm label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working helm
Projects
None yet
Development

No branches or pull requests

2 participants