Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move the validation func from helpers to ramping vus #3616

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

codebien
Copy link
Contributor

@codebien codebien commented Feb 28, 2024

What?

I had it on a draft for a long time and I think is still worth considering the low effort. It amends what we did on #3470 moving the function closer to where they are used.

Why?

The logic implemented is specific for ramping-vus and it shouldn't be reusable for other executors. Then it's better to have it in the specific file instead of the generic helpers.

@codebien codebien self-assigned this Feb 28, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.58%. Comparing base (b217bbf) to head (c4d7837).

❗ Current head c4d7837 differs from pull request most recent head b0da697. Consider uploading reports for the commit b0da697 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3616   +/-   ##
=======================================
  Coverage   73.57%   73.58%           
=======================================
  Files         277      277           
  Lines       20244    20244           
=======================================
+ Hits        14895    14896    +1     
+ Misses       4401     4400    -1     
  Partials      948      948           
Flag Coverage Δ
macos ?
ubuntu 73.49% <100.00%> (-0.03%) ⬇️
windows 73.43% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codebien codebien force-pushed the refactor/ramping-vu-local-validation branch from b0da697 to 37573c8 Compare August 30, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants