Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address jhump/protoreflect deprecations introduced by v1.17.0 #4035

Open
oleiade opened this issue Nov 4, 2024 · 3 comments
Open

Address jhump/protoreflect deprecations introduced by v1.17.0 #4035

oleiade opened this issue Nov 4, 2024 · 3 comments

Comments

@oleiade
Copy link
Member

oleiade commented Nov 4, 2024

As we bumped our github.com/jhump/protoreflect/desc dependency to v0.17.0 we decided to postpone addressing the deprecations this specific version introduced.

Specifically:

  • github.com/jhump/protoreflect/desc is now considered deprecated.

This package is now deprecated. Though use of this package is still needed in order to use a handful of other packages in this repo, many usages should instead prefer the "google.golang.org/protobuf/reflect/protoreflect" package in the Protobuf runtime. In a v2 of this repo, this package will no longer be present.

  • github.com/jhump/protoreflect/desc/protoparse is now considered deprecated.

This package is now deprecated. Most usages should instead prefer the "github.com/bufbuild/protocompile" package. There are some behavioral differences that we hope to address with additional API and enhancements to protocompile. But the protoparse package here is just a veneer on top of protocompile and we plan to do as little maintenance as possible here. In a v2 of this repo, this package will no longer be present.

As a result we have a couple of //nolint:staticcheck comments ignoring those deprecations explicitly. Those can be found in the following files:

Definition of done

We have replaced the deprecated packages import with their more modern counterparts, and the nolint statements have been removed.

@7h3-3mp7y-m4n
Copy link

hey can i pick this issue ?,Thanks!

@mstoykov
Copy link
Contributor

This seems to be very specific to protoreflect, so it might not be as easy as it seems at first. @oleiade did have trouble finding out what was required which is why there is this issue.

But you are definitely welcome to work on it and open a PR

@mstoykov mstoykov removed the triage label Nov 15, 2024
@7h3-3mp7y-m4n
Copy link

I understand this might not be an easy issue to tackle, especially for beginners. However, I’d love to give it a try! I’m still learning, but I’m eager to work on fixing this.

I would really appreciate any guidance or assistance you can offer as I dive into this. I’ll reach out on Slack for more help :)

@mstoykov mstoykov removed their assignment Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants