-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tempo-distributed] add query frontend metrics config #3439
Merged
Sheikh-Abubaker
merged 5 commits into
grafana:main
from
faridtmammadov:query-frontend-metrics-config
Nov 27, 2024
Merged
[tempo-distributed] add query frontend metrics config #3439
Sheikh-Abubaker
merged 5 commits into
grafana:main
from
faridtmammadov:query-frontend-metrics-config
Nov 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faridtmammadov
requested review from
Sheikh-Abubaker,
mapno,
swartz-k,
BitProcessor and
faustodavid
as code owners
November 21, 2024 17:30
faridtmammadov
force-pushed
the
query-frontend-metrics-config
branch
4 times, most recently
from
November 22, 2024 06:43
2d5cbfe
to
be6d477
Compare
faridtmammadov
changed the title
add query frontend metrics config to tempo distributed helm chart
[tempo-distributed] add query frontend metrics config
Nov 22, 2024
faridtmammadov
force-pushed
the
query-frontend-metrics-config
branch
from
November 22, 2024 10:17
be6d477
to
61f3792
Compare
mapno
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Signed-off-by: Farid Mammadov <[email protected]>
faridtmammadov
force-pushed
the
query-frontend-metrics-config
branch
from
November 23, 2024 06:22
61f3792
to
512f9a5
Compare
Signed-off-by: Sheikh-Abubaker <[email protected]>
Signed-off-by: Sheikh-Abubaker <[email protected]>
Sheikh-Abubaker
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing query frontend metrics config. Closes #3323.