-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Forecaster wrapper for Prophet and modify core traits #184
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This isn't ideal because the APIs don't match at all - the forecaster traits don't pass timestamps or anything else down. We could modify them to use an associated type for the data? Not sure how that would affect dyn compatibility (if it exists).
I'm not a huge fan of the API here, may rethink it before merging.
0377c47
to
7e4eee6
Compare
Closing in favour of #191. |
In the second commit of this PR I've reworked the traits so this does kind of work, but it's not ideal (in particular I'm not a big fan of
MutableData
and theset
signature - maybe something likefn set_y(&self, data: &Self::Data) -> Self::Data
would be better?). The lifetimes look complicated as well, we have GATs and all sorts going on. The traits definitely need a rename too (FitData
?).