feat(discovery): Add a remote_relabel component #1368
+1,366
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonswine
force-pushed
the
20240722_add-discovery.remote_relabel
branch
2 times, most recently
from
58bd6d1
to
2d2f80f
Compare
This allows to receive discovery relabeling rules from a remote server using a websocket connection. We plan this for an experimental way to control profile collection with Grafana Cloud Profiles.
simonswine
force-pushed
the
20240722_add-discovery.remote_relabel
branch
from
2d2f80f
to
5e4ee53
Compare
simonswine
changed the title
korniltsev
reviewed
Aug 22, 2024
| var _ component.Component = (*Component)(nil) | ||
|
|
||
| func defaultInstance() string { | ||
| // TODO: This should come from Alloy |
There was a problem hiding this comment.
should this be addressed before merging PR?
korniltsev
approved these changes
Aug 22, 2024
clayton-cornell
approved these changes
Aug 26, 2024
|
|
||
| | Name | Type | Description | Default | Required | | ||
| | --------- | ------------------- | ------------------ | ------- | -------- | | ||
| | `targets` | `list(map(string))` | Targets to relabel | | yes | |
There was a problem hiding this comment.
Suggested change
| | `targets` | `list(map(string))` | Targets to relabel | | yes | | |
| | `targets` | `list(map(string))` | Targets to relabel. | | yes | |
|
|
||
| | Name | Type | Description | Default | Required | | ||
| | --------------------- | ---------- | ------------------------------------------------------------------ | --------- | -------- | | ||
| | `url` | `string` | Full URL to the websocket server. Needs to start with ws:// wss:// | | yes | |
There was a problem hiding this comment.
Suggested change
| | `url` | `string` | Full URL to the websocket server. Needs to start with ws:// wss:// | | yes | | |
| | `url` | `string` | Full URL to the websocket server. Must start with `ws://` or `wss://`. | | yes | |
|
Hey, thanks for opening a PR, that's an interesting idea :) Adding such a component is a big deal, it would have been better to discuss it over a proposal (it's not too late to create one now and use this PR as a POC). |
wildum
requested changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to receive discovery relabelling rules from a remote server using a websocket connection.
We plan this for an experimental way to control profile collection with Grafana Cloud Profiles very dynamically. Currently the only backend available is the settings server for Pyroscope (grafana/pyroscope#3416)