Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build dependency with the latest Variant API supported #447

Open
cdsap opened this issue Feb 18, 2023 · 3 comments
Open

Update build dependency with the latest Variant API supported #447

cdsap opened this issue Feb 18, 2023 · 3 comments
Assignees

Comments

@cdsap
Copy link
Member

cdsap commented Feb 18, 2023

Once we updated the AGP version in the classpath to 7.3.1, we still need to point to the latest stable version of the AGP.
https://github.com/gradle/android-cache-fix-gradle-plugin/blob/main/build.gradle#L26

The new variant API is available in recent versions and it's a pre-requisite to start reworking the workaround variant logic with types provided in the new API.
The old variant is going to be removed in AGP 9.

@cdsap cdsap changed the title Update AGP latest version Update build dependency with the latest Variant API supported Feb 22, 2023
@runningcode
Copy link
Contributor

@cdsap is there anything else we need to do here?

@runningcode
Copy link
Contributor

Can you check if we still have usages of the Variant API?

@cdsap
Copy link
Member Author

cdsap commented Dec 21, 2023

Hi, we have still the JdkImageWorkaround with references like:

            android.unitTestVariants.all(configureVariant)
            android.applicationVariants.all(configureVariant)

https://github.com/gradle/android-cache-fix-gradle-plugin/blob/main/src/main/groovy/org/gradle/android/workarounds/JdkImageWorkaround.groovy#L66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants