Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression in imageformat for Canon EOS M10 #1060

Open
msmeissn opened this issue Nov 21, 2024 · 8 comments
Open

regression in imageformat for Canon EOS M10 #1060

msmeissn opened this issue Nov 21, 2024 · 8 comments
Labels
Canon tagging canon reports

Comments

@msmeissn
Copy link
Contributor

Describe the bug

--get-config imageformat

returns

Label: Image Format
Readonly: 0
Type: RADIO
Current: Large Normal JPEG
Choice: 0 Large Normal JPEG
END

in 2.5.31

In current GIT:
Label: Image Format
Readonly: 0
Type: RADIO
Current: (null)
END

Name the camera

Canon EOS M10

libgphoto2 and gphoto2 version

2.5.31.1 current GIT vs 2.5.31

To Reproduce
Steps to reproduce the behavior:

gphoto2 --get-config imageformat

@msmeissn msmeissn added the Canon tagging canon reports label Nov 21, 2024
@msmeissn
Copy link
Contributor Author

eos.log 2.5.31 logfile
eos-new.log 2.5.31.1 logfile

@msmeissn
Copy link
Contributor Author

@axxel if you could take a look perhaps

@msmeissn
Copy link
Contributor Author

in 2.5.31 it is coded as 0x200
in 2.5.31 it is coded as 0x2ff

@msmeissn
Copy link
Contributor Author

i now emit the default even if the ENUM is empty

@msmeissn
Copy link
Contributor Author

but perhaps axxel has a better fix

@axxel
Copy link
Contributor

axxel commented Nov 22, 2024

Based on your fix, it seems the problem is that the M10 reports a current value that it actually does not enumerate as a valid value?

@msmeissn
Copy link
Contributor Author

Yes, it does not return an enumeration, but a value.

Might depend on the camera mode, but the camera is currently in Manual Mode

@axxel
Copy link
Contributor

axxel commented Nov 22, 2024

Apart from the code duplication in your fix, I don't see a better approach then. I'll post a cosmetic fix for that at some point in time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Canon tagging canon reports
Projects
None yet
Development

No branches or pull requests

2 participants