Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tolerant undefined callback #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

tolerant undefined callback #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/setupCommands.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ module.exports = function(Class) {
args[i] = arguments[i];
}

if (args.length > 0 && typeof args[args.length - 1] === 'undefined') {
args.pop();
}

this[fn](cmd, conf, args);
return this;
};
Expand Down
14 changes: 13 additions & 1 deletion test/miscCommands.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict';
// not really tests but being used to ensure things are working
var RedisClustr = require('../src/redisClustr');
var RedisClustr = require('../src/RedisClustr');

var c = new RedisClustr({
servers: [
Expand Down Expand Up @@ -32,6 +32,18 @@ c.eval('redis.call("set", KEYS[1], ARGV[1]); return redis.call("get", KEYS[1]);'
console.log('eval', err, resp);
});

function delKey(callback) {
c.del('whateverkey', callback);
}

delKey(function(err) {
if (err) return console.error('del error', err);

console.log('del');
});

delKey();

var todo = [
function(done) {
var m = c.multi();
Expand Down