Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Spanner Request Options Tags #525

Open
ahr9n opened this issue Nov 28, 2024 · 0 comments · May be fixed by #558
Open

Support Spanner Request Options Tags #525

ahr9n opened this issue Nov 28, 2024 · 0 comments · May be fixed by #558
Assignees
@olavloite
Labels
api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@ahr9n
Copy link

ahr9n commented Nov 28, 2024 •
edited
Loading

Cloud Spanner API enables tags [request_tag / transaction_tag] for RequestOptions parameter in requests which used for statistics collection on spanner insights, and can be helpful on detecting anomalies and improving spanner database queries / transactions.

RequestOptions Reference
@ahr9n ahr9n added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Nov 28, 2024
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API. label Nov 28, 2024
@olavloite olavloite assigned olavloite and unassigned harshachinta Nov 28, 2024
olavloite added a commit that referenced this issue Dec 9, 2024
@olavloite
feat: support transaction and request tags in dbapi
ff64c6e 
Adds support for setting transaction tags and request tags in dbapi.
This makes these options available to frameworks that depend on
dbapi, like SQLAlchemy and Django.

Towards #525
olavloite added a commit to googleapis/python-spanner that referenced this issue Dec 9, 2024
@olavloite
feat: support transaction and request tags in dbapi
9031124 
Adds support for setting transaction tags and request tags in dbapi.
This makes these options available to frameworks that depend on
dbapi, like SQLAlchemy and Django.

Towards googleapis/python-spanner-sqlalchemy#525
@olavloite olavloite mentioned this issue Dec 9, 2024
Open
@olavloite olavloite linked a pull request Dec 17, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olavloite olavloite

Labels
api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support request and transaction tags googleapis/python-spanner-sqlalchemy
3 participants
@olavloite @ahr9n @harshachinta