-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set db.query.text
OpenTelemetry attribute
#2061
base: main
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@@ -42,7 +42,6 @@ | |||
TEST_SPAN_ATTRIBUTES = {"foo": "baz"} | |||
|
|||
|
|||
@pytest.mark.skipif(opentelemetry is None, reason="Require `opentelemetry`") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not possible to add marks to fixtures, this was wrong.
query = getattr(job_ref, "query", None) | ||
if query is not None: | ||
job_attributes["db.query.text"] = query |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"query"
is only available when the job is a QueryJob
.
I've signed CLA. |
db.query.text
OpenTelemetry attributedb.query.text
OpenTelemetry attribute
db.query.text
attribute to the spans? #2042