-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow to_gbq
to run without bigquery.tables.create
permission.
#539
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the investigation and the fix!
Note: this might make it harder to create tables via the load job as I had planned in #425 but we can address that if/when we try to do that.
Thanks! In the current design you already create the table before the loading. python-bigquery-pandas/pandas_gbq/gbq.py Lines 1153 to 1191 in 439d588
And when you load you create your own JobConfig. python-bigquery-pandas/pandas_gbq/load.py Lines 120 to 122 in 439d588
I guess that once you add the option to let the user provide config then you can go with that config and not create one of yours and otherwise create a default config with reasonable default. |
Fixes #538 🦕