Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): update GAPIC fixtures for latest updates #7819

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Nov 8, 2024

No description provided.

@bshaffer bshaffer marked this pull request as ready for review November 11, 2024 19:37
@bshaffer bshaffer requested review from a team as code owners November 11, 2024 19:37
@@ -49,7 +49,7 @@ items:
-
id: '↳ bounding_box'
var_type: '<xref uid="\Google\Cloud\Vision\V1\BoundingPoly">Google\Cloud\Vision\V1\BoundingPoly</xref>'
description: "The bounding box for the word. The vertices are in the order of top-left, top-right, bottom-right, bottom-left. When a rotation of the bounding box is detected the rotation is represented as around the top-left corner as defined when the text is read in the 'natural' orientation. For example: * when the text is horizontal it might look like: 0----1 | | 3----2 * when it's rotated 180 degrees around the top-left corner it becomes: 2----3 | | 1----0 and the vertex order will still be (0, 1, 2, 3)."
description: "The bounding box for the word. The vertices are in the order of top-left, top-right, bottom-right, bottom-left. When a rotation of the bounding box is detected the rotation is represented as around the top-left corner as defined when the text is read in the 'natural' orientation. For example: * * when the text is horizontal it might look like: 0----1 | | 3----2 * * when it's rotated 180 degrees around the top-left corner it becomes: 2----3 | | 1----0 and the vertex order will still be (0, 1, 2, 3)."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there two * here, is it something like created a list item and then surround the text with *?

Copy link
Contributor Author

@bshaffer bshaffer Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This matches the source protos

* * when it's rotated 180 degrees around the top-left corner it becomes:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hectorhammett Hectorhammett self-requested a review November 11, 2024 19:44
@bshaffer bshaffer merged commit ca2ba78 into main Nov 11, 2024
25 checks passed
@bshaffer bshaffer deleted the update-vision-docfx-fixtures branch November 11, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants