PHP Reference Docs not generating for new releases

[bshaffer]

See https://cloud.google.com/php/docs/reference

Since at least March 22nd (v0.239.0) and at most January 12th (v0.231.0), the new releases have not been updating the reference documentation. There must be errors somewhere in the pipeline and we need to debug them to find out why this is happening.

The error could be anywhere from the docfx generation (this is covered by unit tests, so it's doubtful), to the uploading to the storage bucket, to the processing that happens in kokoro.

This may be related to the failing release jobs (#6824), although those have been failing for a different reason (I believe for the reasons described in #6595)

[bshaffer]

Okay I think I found the problem. If you look at the last confirmed successful release (v0.231.0), you'll notice that the triggered docs job ends in docs/docs:

Triggered job: cloud-devrel/client-libraries/php/google-cloud-php/docs/docs (2024-01-12T19:19:16.216Z)

However, starting with the next release (v0.232.0), the docs job ends in just docs:

Triggered job: cloud-devrel/client-libraries/php/google-cloud-php/docs (2024-01-19T16:19:58.203Z)

I am not sure what happened to change this, or where this is defined, but I believe it is responsible for the problem we are seeing.

[bshaffer]

I found the error: https://github.com/googleapis/releasetool/pull/518/files#r1583639959

Submitted a fix in googleapis/releasetool#542

[yash30201]

Thank you @bshaffer for finding and fixing this docs issue.

Closing the issue as the fix has been merged and release.

[bshaffer]

Confirmed that this worked, and the most recent release triggered the correct job: #7265 (comment)