-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make redirect host configurable #61
Comments
Hi @hacker-h, I'm having a bit of trouble understanding the request. Would you mind providing a short example? As |
You can basically just launch an ubuntu docker container on docker for windows exposing port 8080:
follow the quickstart steps from https://developers.google.com/drive/api/v3/quickstart/python
paste the credentials.json along with the quickstart script into the container (e.g. with run the script:
open the printed URL in your browser and confirm the access Copy the URL and open a terminal to enter your container:
Use curl to send a GET request against the copied URL from within the container:
You will get an output:
I hope this helps to reproduce and understand the problem. |
I ran into the same problem with docker and would find such a feature very useful. |
I am using docker for windows which runs the docker daemon inside a Hyper-V VM.
This library is used inside a docker container and for authentication purposes the corresponding port is exposed to my machine. This way I can access the launched WSGI server on localhost on my machine, however the server inside the docker container does only listen on the ip behind localhost resolved within the container -> You do not receive an answer for localhost on your machine, only within the container (e.g. with curl)
This could easily be mitigated by passing an empty String as
host
parameter to theFlow.run_local_server
function, but this will raise an error because the redirect url is equal to the chosen host string -> empty URL is not possibleAs a solution the function could be extended by an optional parameter
redirect_host
that defaults to the value ofhost
and is inserted into theredirect_host
variable.The text was updated successfully, but these errors were encountered: