Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to read client secrets from an external source like google secret manager #289

Open
kshitij-enable opened this issue Jul 14, 2023 · 1 comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@kshitij-enable
Copy link

Flow for the client credentials can be instantiated with either 2 methods.

  1. from_client_secrets_file
  2. from_client_config

However, we intend to persist client credentials in an external vault like google secret manager and would like to have an instantiation mechanism by passing the secrets as arguments rather than local file or config.

@sai-sunder-s
Copy link
Contributor

Thank you for your request. IIUC, you would like to

  • store client secret in a vault/secret manager
  • have your own code to fetch the secret at run time and provide as parameter
  • provide clientid, type of client, token_uri and any other info held by client_config as parameters

Is there a reason you cannot create a json yourself with all the info and pass it in to from_client_config?

@sai-sunder-s sai-sunder-s added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

2 participants