Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve definition of Fare Products #367

Closed
isabelle-dr opened this issue Jan 31, 2023 · 0 comments · Fixed by #426
Closed

Improve definition of Fare Products #367

isabelle-dr opened this issue Jan 31, 2023 · 0 comments · Fixed by #426
Assignees
Labels
Change: Clarification Revisions of the current specification to improve understanding. Extension: GTFS-Fares Issues and Pull Requests that focus on GTFS-Fares Extension GTFS Schedule Issues and Pull Requests that focus on GTFS Schedule Status: Pull Request Created Issues that have been transferred to the Pull Request stage.

Comments

@isabelle-dr
Copy link
Collaborator

Problem

There is confusion around what a fare product is in GTFS. Two sources of confusion were brought-up to our attention:

First, the definition of fare_products.txt is:

To describe the different types of tickets or fares that can be purchased by riders.

When in reality, some fare products represent virtual products that can't be purchased (by themselves) by riders, such as a transfer cost.

Second: although fare_poduct_id's type is ID and not Unique ID, it's unclear in the spec that several Fare Products can be grouped under the same fare_product_id, and under which conditions this should be done to ensure an efficient fare design.

Solution

The file definition should be modified to include virtual products that can't be directly bought by riders.
The file definition should give insights on when fare products should be grouped under the same ID.
The definition of fare_poduct_id should be modified to include something like:

Multiple records in fare_products.txt may have the same fare_product_id, in which case all fare products with that ID will be applied when referenced from another file.

@isabelle-dr isabelle-dr added the GTFS Schedule Issues and Pull Requests that focus on GTFS Schedule label Jan 31, 2023
@emmambd emmambd added the Extension: GTFS-Fares Issues and Pull Requests that focus on GTFS-Fares Extension label May 10, 2023
@eliasmbd eliasmbd added Change: Clarification Revisions of the current specification to improve understanding. and removed documentation labels Jan 9, 2024
@tzujenchanmbd tzujenchanmbd linked a pull request Jan 10, 2024 that will close this issue
@eliasmbd eliasmbd added the Status: Pull Request Created Issues that have been transferred to the Pull Request stage. label Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Change: Clarification Revisions of the current specification to improve understanding. Extension: GTFS-Fares Issues and Pull Requests that focus on GTFS-Fares Extension GTFS Schedule Issues and Pull Requests that focus on GTFS Schedule Status: Pull Request Created Issues that have been transferred to the Pull Request stage.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants