Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect SerializedTestRecord type annotation #1015

Open
lalten opened this issue Jun 13, 2022 · 0 comments
Open

Incorrect SerializedTestRecord type annotation #1015

lalten opened this issue Jun 13, 2022 · 0 comments
Assignees
@dbhatman

Comments

@lalten
Copy link
Contributor

lalten commented Jun 13, 2022

In

openhtf/openhtf/output/callbacks/__init__.py

Line 34 in 341aa86

SerializedTestRecord = Union[Text, bytes, Iterator[Union[Text, bytes]]]

I think Iterator should be Iterable, because otherwise

openhtf/openhtf/output/callbacks/__init__.py

Line 136 in 341aa86

elif isinstance(serialized_record, Iterable):

can never happen
@dbhatman dbhatman self-assigned this Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbhatman dbhatman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dbhatman @lalten