Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript CreateFixture method no longer accesses global world variable... #51

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zilluss
Copy link

@zilluss zilluss commented Apr 26, 2015

This fixes the problem from #49 and adds a GetWorld method to b2Body.

@zilluss
Copy link
Author

zilluss commented Apr 26, 2015

The compiled JavaScript files need to be updated by someone else, because my version of emcc creates a ~30kB larger output file and an additional .mem file.

@EJTH
Copy link

EJTH commented Apr 27, 2015

Somebody give this guy a medal, and get this merged into the repo please!

@zilluss
Copy link
Author

zilluss commented Apr 27, 2015

You can get the version I compiled here https://gist.githubusercontent.com/zilluss/ccdf2c17c2d8577ea4dc/raw/14deed4733a4e3798c0993b07e0d76c8671f59ff/liquidfun.js

But as I said, it's a bit larger. The new emcc also fixes #50 partially, so the lengths of positionBuffer/particleCount match, so you don't get problems when rendering them as GL_POINTS. But CreateParticle still creates some strange particles that behave like b2_staticBodies :(

@EJTH
Copy link

EJTH commented Jan 11, 2016

So, is there any chance of this getting merged?

@stewartmiles
Copy link
Contributor

Thanks, though this now needs to be rebased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants