Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message on tag resolution failure #2

Open
halvards opened this issue Mar 10, 2021 · 1 comment
Open

Improve error message on tag resolution failure #2

halvards opened this issue Mar 10, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@halvards
Copy link
Member

Digester currently uses HEAD requests to look up image digests.

If the image registry returns an error, there is no response body to provide additional information about the error.

As long as the HTTP status code was not 429, digester could fall back to a GET request in order to get the error message and surface it to the user.

@halvards halvards added the enhancement New feature or request label Mar 10, 2021
@newtondev
Copy link

This has already been implemented in the gcrane package, please see https://github.com/google/go-containerregistry/blob/main/pkg/crane/digest.go#L45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants