Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[polynomial] Change polynomial ring coefficient type to AnyType and allow a modarith type #1085

Open
asraa opened this issue Nov 11, 2024 · 1 comment
Open

[polynomial] Change polynomial ring coefficient type to AnyType and allow a modarith type #1085

asraa opened this issue Nov 11, 2024 · 1 comment
Assignees
@j2kun

Comments

@asraa
Copy link
Collaborator

asraa commented Nov 11, 2024

This would remove the unnecessary coefficientModulus, since the coefficientType will encode the modulus if we have a modarith type.
copybara-service bot pushed a commit that referenced this issue Nov 12, 2024
@j2kun @copybara-github
Repatriate polynomial dialect
23ee119 
Due to some governance discussions in upstream MLIR [1], we decided it would be appropriate to move the polynomial dialect back into the HEIR tree. We also have some plans to make minor changes to the types, for instance changing the coefficient type to AnyType and removing the coefficient modulus to support things like RNS+modarith coefficient rings, and we felt it would be simpler to just make these changes in tree rather than burden the MLIR community and core maintainers with them. Cf. #1085

[1]: https://discourse.llvm.org/t/rfc-mlir-project-charter-and-restructuring/82896

PiperOrigin-RevId: 695820053
@copybara-service copybara-service bot mentioned this issue Nov 12, 2024
Merged
copybara-service bot pushed a commit that referenced this issue Nov 12, 2024
@j2kun @copybara-github
Repatriate polynomial dialect
d9d14c2 
Due to some governance discussions in upstream MLIR [1], we decided it would be appropriate to move the polynomial dialect back into the HEIR tree. We also have some plans to make minor changes to the types, for instance changing the coefficient type to AnyType and removing the coefficient modulus to support things like RNS+modarith coefficient rings, and we felt it would be simpler to just make these changes in tree rather than burden the MLIR community and core maintainers with them. Cf. #1085

[1]: https://discourse.llvm.org/t/rfc-mlir-project-charter-and-restructuring/82896

PiperOrigin-RevId: 695820053
@j2kun j2kun self-assigned this Nov 12, 2024
copybara-service bot pushed a commit that referenced this issue Nov 12, 2024
@j2kun @copybara-github
Repatriate polynomial dialect
7917567 
Due to some governance discussions in upstream MLIR [1], we decided it would be appropriate to move the polynomial dialect back into the HEIR tree. We also have some plans to make minor changes to the types, for instance changing the coefficient type to AnyType and removing the coefficient modulus to support things like RNS+modarith coefficient rings, and we felt it would be simpler to just make these changes in tree rather than burden the MLIR community and core maintainers with them. Cf. #1085

[1]: https://discourse.llvm.org/t/rfc-mlir-project-charter-and-restructuring/82896

PiperOrigin-RevId: 695820053
copybara-service bot pushed a commit that referenced this issue Nov 12, 2024
@j2kun @copybara-github
Repatriate polynomial dialect
8a5c996 
Due to some governance discussions in upstream MLIR [1], we decided it would be appropriate to move the polynomial dialect back into the HEIR tree. We also have some plans to make minor changes to the types, for instance changing the coefficient type to AnyType and removing the coefficient modulus to support things like RNS+modarith coefficient rings, and we felt it would be simpler to just make these changes in tree rather than burden the MLIR community and core maintainers with them. Cf. #1085

[1]: https://discourse.llvm.org/t/rfc-mlir-project-charter-and-restructuring/82896

PiperOrigin-RevId: 695820053
copybara-service bot pushed a commit that referenced this issue Nov 13, 2024
@j2kun @copybara-github
Repatriate polynomial dialect
421d82d 
Due to some governance discussions in upstream MLIR [1], we decided it would be appropriate to move the polynomial dialect back into the HEIR tree. We also have some plans to make minor changes to the types, for instance changing the coefficient type to AnyType and removing the coefficient modulus to support things like RNS+modarith coefficient rings, and we felt it would be simpler to just make these changes in tree rather than burden the MLIR community and core maintainers with them. Cf. #1085

[1]: https://discourse.llvm.org/t/rfc-mlir-project-charter-and-restructuring/82896

PiperOrigin-RevId: 695820053
copybara-service bot pushed a commit that referenced this issue Nov 13, 2024
@j2kun @copybara-github
Repatriate polynomial dialect
5dac435 
Due to some governance discussions in upstream MLIR [1], we decided it would be appropriate to move the polynomial dialect back into the HEIR tree. We also have some plans to make minor changes to the types, for instance changing the coefficient type to AnyType and removing the coefficient modulus to support things like RNS+modarith coefficient rings, and we felt it would be simpler to just make these changes in tree rather than burden the MLIR community and core maintainers with them. Cf. #1085

[1]: https://discourse.llvm.org/t/rfc-mlir-project-charter-and-restructuring/82896

PiperOrigin-RevId: 696112603
@ZenithalHourlyRate ZenithalHourlyRate mentioned this issue Nov 15, 2024
Open
@github-actions GitHub Actions
Copy link

This issue has 1 outstanding TODOs:

This comment was autogenerated by todo-backlinks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@j2kun j2kun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@j2kun @asraa