Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move camera position to geometry when restoring draw area tasks #2868

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Move camera position to geometry when restoring draw area tasks #2868

wants to merge 1 commit into from
+16 −0

Conversation

shobhitagarwal1612
Copy link
Member

Fixes #2847

@gino-m PTAL?

@shobhitagarwal1612 shobhitagarwal1612 removed the request for review from anandwana001 November 23, 2024 08:19
@codecov Codecov
Copy link

codecov bot commented Nov 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 61.32%. Comparing base (59ae309) to head (3d6ac2f).

Files with missing lines Patch % Lines
...ollection/tasks/polygon/DrawAreaTaskMapFragment.kt 0.00% 5 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #2868      +/-   ##
============================================
- Coverage     61.37%   61.32%   -0.05%     
  Complexity     1176     1176              
============================================
  Files           266      266              
  Lines          6325     6330       +5     
  Branches        903      904       +1     
============================================
  Hits           3882     3882              
- Misses         1916     1921       +5     
  Partials        527      527
Files with missing lines Coverage Δ
...ollection/tasks/polygon/DrawAreaTaskMapFragment.kt 20.83% <0.00%> (-5.49%) ⬇️
---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandwana001 anandwana001 anandwana001 approved these changes

@gino-m gino-m Awaiting requested review from gino-m

Assignees

@gino-m gino-m

@anandwana001 anandwana001

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Geometry data collection tasks] Geometry sometimes not visible on map when returning to task
3 participants
@shobhitagarwal1612 @anandwana001 @gino-m