Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data collection] Restore position to last active task when restoring from draft #2871

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[Data collection] Restore position to last active task when restoring from draft #2871

wants to merge 3 commits into from

Conversation

shobhitagarwal1612
Copy link
Member

@shobhitagarwal1612 shobhitagarwal1612 commented Nov 24, 2024 •
edited
Loading

Fixes #2832

Reuses currentTaskId mechanism to set the initial task position when restoring from draft.

draft-position.webm

@sufyanAbbasi there is some weirdness with task sequence when moving to previous task from restored position. Do you have any ideas?

@sufyanAbbasi @gino-m PTAL?

@codecov Codecov
Copy link

codecov bot commented Nov 24, 2024

Codecov Report

Attention: Patch coverage is 10.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 61.33%. Comparing base (59ae309) to head (cbd9f94).

Files with missing lines Patch % Lines
...d/persistence/local/room/converter/ConverterExt.kt 0.00% 2 Missing ⚠️
...ome/mapcontainer/HomeScreenMapContainerFragment.kt 0.00% 2 Missing ⚠️
...android/ground/model/submission/DraftSubmission.kt 0.00% 1 Missing ⚠️
...istence/local/room/entity/DraftSubmissionEntity.kt 0.00% 1 Missing ⚠️
.../android/ground/repository/SubmissionRepository.kt 0.00% 1 Missing ⚠️
...ground/ui/datacollection/DataCollectionFragment.kt 0.00% 0 Missing and 1 partial ⚠️
...oogle/android/ground/ui/home/HomeScreenFragment.kt 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #2871      +/-   ##
============================================
- Coverage     61.37%   61.33%   -0.04%     
- Complexity     1176     1177       +1     
============================================
  Files           266      266              
  Lines          6325     6332       +7     
  Branches        903      904       +1     
============================================
+ Hits           3882     3884       +2     
- Misses         1916     1923       +7     
+ Partials        527      525       -2
Files with missing lines Coverage Δ
.../src/main/java/com/google/android/ground/Config.kt 100.00% <ø> (ø)
...round/ui/datacollection/DataCollectionViewModel.kt 73.60% <100.00%> (+2.03%) ⬆️
...android/ground/model/submission/DraftSubmission.kt 0.00% <0.00%> (ø)
...istence/local/room/entity/DraftSubmissionEntity.kt 0.00% <0.00%> (ø)
.../android/ground/repository/SubmissionRepository.kt 18.60% <0.00%> (ø)
...ground/ui/datacollection/DataCollectionFragment.kt 54.00% <0.00%> (-2.00%) ⬇️
...oogle/android/ground/ui/home/HomeScreenFragment.kt 54.45% <0.00%> (-0.55%) ⬇️
...d/persistence/local/room/converter/ConverterExt.kt 78.10% <0.00%> (-0.52%) ⬇️
...ome/mapcontainer/HomeScreenMapContainerFragment.kt 16.86% <0.00%> (-0.20%) ⬇️
---- 🚨 Try these New Features:

@shobhitagarwal1612 shobhitagarwal1612 changed the title [Data collection] Restore position to last task when restoring draft [Data collection] Restore position to last active task when restoring draft Nov 24, 2024
@shobhitagarwal1612 shobhitagarwal1612 changed the title [Data collection] Restore position to last active task when restoring draft [Data collection] Restore position to last active task when restoring from draft Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandwana001 anandwana001 Awaiting requested review from anandwana001

@gino-m gino-m Awaiting requested review from gino-m

At least 1 approving review is required to merge this pull request.

Assignees

@gino-m gino-m

@sufyanAbbasi sufyanAbbasi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Data collection] Data collection returns to first task/step after draft state restored
3 participants
@shobhitagarwal1612 @gino-m @sufyanAbbasi