Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radians vs degrees in quaternion logic #305

Open
andrewwarrington opened this issue Jan 31, 2023 · 1 comment
Open

Radians vs degrees in quaternion logic #305

andrewwarrington opened this issue Jan 31, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@andrewwarrington
Copy link

andrewwarrington commented Jan 31, 2023

Hi Brax,

When converting between quaternions and Euler angles, the function euler_to_quat takes the Euler angles in degrees, but the inverse function, quat_to_euler, returns the Euler angles in radians.

It is documented, and it is a relatively small fix to make in your own code to wrap one of these functions to work either exclusively in degrees or radians; but the code is not really self-consistent (and cost me a day's head-scratching, although I suppose I should have read the docstring...!).

Changing this interface would be a wildly breaking change, so I don't know if there is a quick-fix -- maybe explicitly adding wrapped pairs functions that work in exclusively radians or degrees? Maybe this is something for a later release?

Thanks,
Andy

@btaba btaba added enhancement New feature or request good first issue Good for newcomers labels Feb 10, 2023
@varshneydevansh
Copy link

Can I look into this? Please =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants