fix: Use a readonly textarea for non-editable comments. #8632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcallen
approved these changes
Nov 1, 2024
|
Since nothing here appears to be breaking, it could probably have been done in v11 instead. |
gonfunko
force-pushed
the
readonly-comments
branch
from
87d516a
to
19546e1
Compare
Rebased accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #2917
Proposed Changes
This PR uses the regular block comment bubble, but with the textarea's
readonlyattribute set, for displaying block comments in readonly workspaces. This allows the comments to be scrolled (and their text selected/copied) and otherwise interacted with normally, while prohibiting edits.