Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockly Music - notes position on staff are off by an octave #217

Open
moniika opened this issue Feb 8, 2021 · 0 comments
Open

Blockly Music - notes position on staff are off by an octave #217

moniika opened this issue Feb 8, 2021 · 0 comments

Comments

@moniika
Copy link
Contributor

moniika commented Feb 8, 2021

In the music game, the notes appear in the wrong position of the staff in the dropdown picker and in the visualizer on the left of the screen.

The note currently played for C4 is middle C (~262Hz).
Middle C is not determined by the note name (in midi standard middle c can be named C3 or C5), but rather by the pitch (frequency). Middle C should always appear on the first ledger line below the treble staff.

image

However, in the game, the middle C note incorrectly appears an octave above where it should be.

image

Context

https://groups.google.com/g/blockly/c/br4oZAHHWww

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant