Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A possible mistake in the FLOPs calculation of attn_output_layer_norm in the file flops_computation.py #121

Open
hrheru2021 opened this issue May 13, 2021 · 0 comments

Comments

@hrheru2021
Copy link

In the file flops_computation.py, I find that the FLOPs calculation of attn_output_layer_norm (in Line 77) does not include self.h multiplication factor. This is different from the FLOPs calculation of output_layer_norm (in Line 85) which includes self.h multiplication factor. It seems that the code logic of these two lines is exactly the same, so that self.h multiplication factor is missed in the FLOPs calculation of attn_output_layer_norm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant