Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[research] Prepare an example reproducing partial command output issue #1091

Open
1 task done
shadeofblue opened this issue Jan 25, 2023 · 3 comments
Open
1 task done
Labels
sdk-request issue requested by SDK team

Comments

@shadeofblue
Copy link
Contributor

shadeofblue commented Jan 25, 2023

As in rare occasion, output from exe script can be cut at the end. Its hard to tell, who is responsible for that problem, but its good idea to try pin it.

We need to prepare a yapapi example that reproduces an issue where the full output of a command is not returned.

Maybe we could transfer a textfile to the VM, have a script output that to stdout and stderr and verify if what comes back matches what we had transferred. We may also just print a logfile or a very long directory listing.

Todo:

  • Prepare the example that confirms cutting the long exe script output
@shadeofblue shadeofblue changed the title [research] prepare a yapapi example that reproduces an issue with full output of a command not being returned [research] prepare an example reproducing partial command output issue Jan 25, 2023
@evik42
Copy link

evik42 commented Jan 25, 2023

When I was working on golemfactory/yagna#2035 I created an image with a 1mb text file and run the script cat textfile counting the received bytes.
Not sure what the research is about as the problem is in ya-runtime-vm and the fix was rejected by SDK team because it broke some examples where the background process is not closing stdout/stderr before going to the background.
I think we agreed that the fix might be introduced later but with a flag to notify if the command is expected to wait until stdout/stderr is closed before returning.

@approxit approxit changed the title [research] prepare an example reproducing partial command output issue [research] Prepare an example reproducing partial command output issue Feb 7, 2023
@lucekdudek lucekdudek self-assigned this Feb 15, 2023
@lucekdudek
Copy link
Contributor

There is an example on a branch in yapapi that tests if output command output contains entire expected data
https://github.com/golemfactory/yapapi/tree/ld/partial-command-output-issue-example/examples/huge-output-command

@approxit approxit assigned shadeofblue and unassigned lucekdudek Feb 24, 2023
@shadeofblue shadeofblue added the sdk-request issue requested by SDK team label Mar 3, 2023
@shadeofblue shadeofblue removed their assignment Mar 3, 2023
@jalas167
Copy link

this is handled by .core under: golemfactory/yagna#2478

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sdk-request issue requested by SDK team
Projects
None yet
Development

No branches or pull requests

4 participants