Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is possible to sign expired cert and use it as an issuer #23

Open
pwalski opened this issue May 25, 2023 · 1 comment
Open

It is possible to sign expired cert and use it as an issuer #23

pwalski opened this issue May 25, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@pwalski
Copy link
Contributor

pwalski commented May 25, 2023

What:
Add suitable warnings when using expired certificates in scenarios like below.

Problems:

  • It is possible to sign cert with ValidityPeriod set to past (is expired).
  • It is possible to sign cert using expired Golem cert.
  • It is possible to sign cert which ValidityPeriod is longer than signing cert's.
    I report it because I believe openssl rejects attempt to sign expired cert, so maybe we should behave the same. It also does not allow for cert issuer expiring before signed cert.
@pwalski pwalski changed the title It is possible to sign already expired cert It is possible to sign expired cert May 25, 2023
@pwalski pwalski changed the title It is possible to sign expired cert It is possible to sign expired cert and use it as an issuer May 25, 2023
@pwalski
Copy link
Contributor Author

pwalski commented May 25, 2023

It is good that library verification method rejects not expired cert signed by expired cert, but it means rejection will happen on Provider side during Negotiation, not on the side of author of an application with Audited Payload the moment they will try to sign it using invalid certificate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant