Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid duplication of types when using generated stubs #83

Open
vigoo opened this issue Sep 13, 2024 · 0 comments
Open

Avoid duplication of types when using generated stubs #83

vigoo opened this issue Sep 13, 2024 · 0 comments
Assignees
Milestone

Comments

@vigoo
Copy link
Contributor

vigoo commented Sep 13, 2024

When having a circular reference through generated stubs, some data types are getting inlined in the generated dependency-WITs because the stub WITs cannot refer to the top level package.

To avoid this, we can change how stub dependencies are added to a project, by doing a one-time transformation of the caller project's WIT directory, introducing a new top-level WIT package and moving the original user defined one to the wit/deps dependencies. This way we don't have to inline the user-defined types in the generated stubs.

image

@vigoo vigoo added this to the Golem 1.1 milestone Sep 13, 2024
@vigoo vigoo transferred this issue from golemcloud/golem Sep 13, 2024
@noise64 noise64 self-assigned this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants