Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix go_vet and golint issues #78

Open
njourdane opened this issue May 21, 2019 · 1 comment
Open

Fix go_vet and golint issues #78

njourdane opened this issue May 21, 2019 · 1 comment

Comments

@njourdane
Copy link

I made a PR to add Nuklear in the awesome-go list.

It seems that one required thing for this is to fix some issues in the go_vet and golint, as explained by a collaborator:

The goreportcard-tool lists the result of a few common linters used for go projects. Vet for example reports suspicous constructs, whereas golint lists some formal issues.

Most of those issues can be quickly fixed and in addition to improve code quality, figuring in the awesome-go list will improve Nuklear visibility.

@xlab
Copy link
Member

xlab commented May 21, 2019

Since it's just a lot of bindings, I'm afraid it'd be hard to pass those tests in the code that is generated and optimised for Cgo.

Also, I honestly don't see profit from making Nuklear more visible, it's relative hard to use.
I'd better choose https://github.com/fyne-io/fyne if I'm about to start an GUI project.

Cheers. Thanks for PR, I'll see what I can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants