Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keypad enter key does not work #60

Open
jkvatne opened this issue Jun 26, 2018 · 2 comments
Open

Keypad enter key does not work #60

jkvatne opened this issue Jun 26, 2018 · 2 comments

Comments

@jkvatne
Copy link
Contributor

jkvatne commented Jun 26, 2018

There is a problem with the handling of enter keys. The backend returns different codes for the normal enter key and the keypad enter key, but nuklear.h checks only one. This is very confusing. We can either change nuklear.h and check both, or we can modify impl_glfw_common.go to deliver the same code for both . Both are easy to do. Which way is best?

@jkvatne
Copy link
Contributor Author

jkvatne commented Jun 26, 2018

In fact, there is another, related problem. The enter keys have a very fast repeat. The other keys does not repeat when held down, but the enter keys repeat after just a fraction of a second. I can not see any reason for this.

@xlab
Copy link
Member

xlab commented Jun 26, 2018

we can modify impl_glfw_common.go to deliver the same code for both .

this is correct, as the package should not modify the original nuklear.h

key repeats are managed by the platform code also

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants