-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Special character in URL has new behaviour since 0.123.0 #12241
Comments
Reported here as well: I know we made a "hyphen retention" change to address another issue (I think to retain three consecutive hyphens), but I'm not sure if the above is intentional. |
@bep, is the above here to stay (and therefore I should change my aliases, links and so on), or if this is an unexpected behaviour? Thanks. |
I believe this is the culprit (which I'm assuming is an intentional decision) Line 297 in 9ca1de0
|
Of a very small sampling (n=219) of sites in the wild running v0.100.0 or later, 23% are already running v0.123.0 or later, so... even if this wasn't intentional, changing it again may be unwise. |
If it wasn't intentional, I was hoping hugo would offer a way to opt-out (and preserve the old behaviour). |
@jmooring looking at it again, the current implementation doesn't make much sense though
Before I embark on a fixing journey, I wanted clarity on whether this is intentional or not. |
I think I'm an outlier because we have lots of pages with various special characters and spaces in them, which I will now correct. I am however still puzzled on why the new behaviour is not consistent across different characters.
Cheers. |
@jmichelgarcia We'll handle further questions here: |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
What version of Hugo are you using (
hugo version
)?latest (123.8)
When did the problem appear?
0.123.0
Problem
I am using Docsy and I have a file:
content/en/docs/Administration/On-Premises Deployments/Architecture & System Requirements/_index.md
FontMatter wise:
Until
0.122.0
that page was being rendered with this url:https://[domain]/en/docs/administration/on-premises-deployments/architecture-system-requirements/
After upgrading to
0.123.0
, it is now being rendered as:https://[domain]/en/docs/administration/on-premises-deployments/architecture--system-requirements/
notice the
--
instead of-
.Is this expected?
I'm going through the release notes and code, to see if I missed anything.
Many thanks!
The text was updated successfully, but these errors were encountered: