extras: Allow superscript to begin with plus, minus, or single quote #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmooring
force-pushed
the
superscript-punctuation-30
branch
from
33c0e92 to
8cef28b
Compare
|
I don't have a strong opinion on this, but the code looks correct. I don't mind having small hacks like these if the cause is .. nobel enough; and I guess not having negative exponents is making the superscript feature ... less than useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #30
In my view an upstream change that would help us is unlikely. This is admittedly a trick, but it is (a) isolated to superscript parsing, and (b) only applicable to the plus, minus, and single quote symbols.
The goldmark parser.ScanDelimiter function receives the line, but doesn't pass it on to anything else. So all we're doing is replacing the plus, minus, or single quote symbol with the letter "z" if the symbol is the first character after the delimiter. Using the letter "z" was an arbitrary choice.
I included the plus sign because it is common in chemistry, and I include the single quote because it is common in math.
Other common superscripts include the registered trademark, trademark, and service mark symbols, but their Unicode representations are already superscript-y (e.g., Hugo®, Hugo™, Hugo ℠).