Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translation priorities in Localization contributing page #10319

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

tetrapod00
Copy link
Contributor

Updated the word counts to roughly match the current "All strings" count on Weblate.

Also changed the recommended priority of translations to editor interface, then class reference, then manual. As I don't have first-hand experience with translation, I'm not 100% sure about that order. I asked in the translation RC and got a couple agreements, but I'm not sure how unanimous that is. It does match the concept of treating the class reference as more of a source of truth, since it's in the main repo and included in the engine itself.

@tetrapod00 tetrapod00 added enhancement area:contributing Issues and PRs related to the Contributing/Development section of the documentation labels Nov 25, 2024
Copy link
Member

@Piralein Piralein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if the word count is needed anyway

Copy link
Member

@mhilbrunner mhilbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure whether the word count is useful or should be dropped. If it is, maybe we should add one of those UPDATE comments here so try to remember?

@Mickeon
Copy link
Contributor

Mickeon commented Nov 25, 2024

Maybe it's best to drop it, yeah. If people want to see the count is right there on Weblate. The actual numbers are only going to grow and cannot be maintained accurate every time.

@tetrapod00
Copy link
Contributor Author

tetrapod00 commented Nov 25, 2024

It seems reasonable to drop the word count entirely. I do think there is some value in knowing the scale of the text to translate, to at least an order of magnitude, as well as the relative sizes of the three subcategories.

This PR is updated to remove the counts entirely, which we seem to have reasonable consensus on.

As an alternative, we could list the total word count which right now is ~1,000,000, but not the subcounts.

@tetrapod00 tetrapod00 changed the title Update word counts and translation priorities in Localization contributing page Update translation priorities in Localization contributing page Nov 25, 2024
@mhilbrunner mhilbrunner merged commit 109de08 into godotengine:master Nov 26, 2024
1 check passed
@mhilbrunner
Copy link
Member

This seems fine to me :) Thank you, merged.

@tetrapod00 tetrapod00 deleted the translate-update branch November 27, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:contributing Issues and PRs related to the Contributing/Development section of the documentation enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants