Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AnimationTree documentation simplification and expansion #10072

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

AnimationTree documentation simplification and expansion #10072

wants to merge 1 commit into from
+180 −134

Conversation

saabdo42
Copy link

@saabdo42 saabdo42 commented Oct 11, 2024 •
edited
Loading

Simplified AnimationTree language, added documentation for Advance Expression, made images webp and colorblind friendly with more descriptive names.

Fixes: #9699
Fixes: #7753
Fixes: #7658

@AThousandShips AThousandShips added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Oct 11, 2024
@AThousandShips AThousandShips requested a review from a team October 11, 2024 16:58
@fire
Copy link
Member

fire commented Oct 11, 2024

Is there a good way to preview doc changes?

@fire fire changed the title AnimationTree simplification and expansion AnimationTree documentation simplification and expansion Oct 11, 2024
@fire
Copy link
Member

fire commented Oct 11, 2024

Not familiar with spinx errors.

Warning, treated as error:
/home/runner/work/godot-docs/godot-docs/tutorials/animation/animation_tree.rst:19:Title underline too short.

AnimationTree and AnimationPlayer
-------------------------
make: *** [Makefile:37: dummy] Error 2

@saabdo42
Copy link
Author

Ok just fixed that error

@saabdo42
Copy link
Author

I'm not sure how to assign issues to pull requests, but this fixes #9699 and #7753

@fire
Copy link
Member

fire commented Oct 12, 2024 •
edited
Loading

Add this to your first post.

Fixes: https://github.com/godotengine/godot-docs/issues/9699
Fixes: https://github.com/godotengine/godot-docs/issues/7753

@skyace65
Copy link
Contributor

This PR needs to be rebased.

@skyace65 skyace65 added the needs work Needs additional work by the original author, someone else or in another repo. label Oct 29, 2024
@saabdo42
Copy link
Author

What does that mean? (sorry lol)

@fire
Copy link
Member

fire commented Oct 31, 2024

Let me know if you have any questions after reading this. https://docs.godotengine.org/en/stable/contributing/workflow/pr_workflow.html

@skyace65 skyace65 removed the needs work Needs additional work by the original author, someone else or in another repo. label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement
Projects
Animation Team Issue Triage
Status: Work in progress
Milestone
No milestone
4 participants
@saabdo42 @fire @skyace65 @AThousandShips