chore(deps): update all non-major dependencies #4733
reviewdog [golangci] report
reported by reviewdog 🐶
Findings (59)
internal/service/snapshot_test.go|138 col 25| unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
internal/service/upload_test.go|166 col 25| unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
mock/worker/executor.go|38 col 13| SA1019: library.Executor is deprecated: use Executor from github.com/go-vela/server/api/types instead. (staticcheck)
mock/worker/executor.go|58 col 11| SA1019: library.Executor is deprecated: use Executor from github.com/go-vela/server/api/types instead. (staticcheck)
executor/local/step.go|46 col 27| unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
executor/local/service.go|49 col 30| unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
executor/local/build_test.go|426 col 22| unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
executor/local/build_test.go|470 col 19| unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
executor/local/build_test.go|515 col 19| unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
runtime/docker/container.go|303 col 16| SA1019: types.ExecConfig is deprecated: use [container.ExecOptions]. (staticcheck)
runtime/docker/container.go|315 col 78| SA1019: types.ExecStartCheck is deprecated: use [container.ExecStartOptions] or [container.ExecAttachOptions]. (staticcheck)
runtime/docker/network.go|23 col 10| SA1019: types.NetworkCreate is deprecated: use [network.CreateOptions]. (staticcheck)
runtime/docker/network.go|45 col 10| SA1019: types.NetworkInspectOptions is deprecated: use [network.InspectOptions]. (staticcheck)
executor/linux/build_test.go|1100 col 19| unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
executor/linux/secret.go|209 col 37| non-wrapping format verb for fmt.Errorf. Use %w
to format errors (errorlint)
executor/linux/secret.go|226 col 37| non-wrapping format verb for fmt.Errorf. Use %w
to format errors (errorlint)
executor/linux/secret.go|243 col 37| non-wrapping format verb for fmt.Errorf. Use %w
to format errors (errorlint)
executor/linux/build_test.go|1549 col 5| if statements should only be cuddled with assignments (wsl)
executor/linux/build_test.go|987 col 6| if statements should only be cuddled with assignments used in the if statement itself (wsl)
executor/linux/build_test.go|863 col 5| only one cuddle assignment allowed before if statement (wsl)
executor/linux/build_test.go|1605 col 4| if statements should only be cuddled with assignments (wsl)
executor/linux/build_test.go|212 col 4| if statements should only be cuddled with assignments (wsl)
executor/linux/build_test.go|322 col 4| defer statements should only be cuddled with expressions on same variable (wsl)
executor/linux/build_test.go|384 col 4| ranges should only be cuddled with assignments used in the iteration (wsl)
executor/linux/build_test.go|697 col 6| if statements should only be cuddled with assignments used in the if statement itself (wsl)
executor/linux/build_test.go|945 col 6| only one cuddle assignment allowed before range statement (wsl)
executor/linux/build_test.go|1503 col 5| only one cuddle assignment allowed before if statement (wsl)
executor/linux/build_test.go|1595 col 4| ranges should only be cuddled with assignments used in the iteration (wsl)
executor/linux/build_test.go|207 col 6| if statements should only be cuddled with assignments used in the if statement itself (wsl)
executor/linux/build_test.go|982 col 4| ranges should only be cuddled with assignments used in the iteration (wsl)
executor/linux/build_test.go|165 col 5| only one cuddle assignment allowed before if statement (wsl)
executor/linux/build_test.go|840 col 4| defer statements should only be cuddled with expressions on same variable (wsl)
executor/linux/build_test.go|145 col 4| defer statements should only be cuddled with expressions on same variable (wsl)
internal/context/context_test.go|148 col 4| assignments should only be cuddled with other assignments (wsl)
mock/docker/container.go|127 col 9| SA1019: types.ContainerExecInspect is deprecated: use [container.ExecInspect]. (staticcheck)
mock/docker/container.go|388 col 9| SA1019: types.ContainerPathStat is deprecated: use [container.PathStat]. (staticcheck)
mock/docker/container.go|397 col 9| SA1019: types.ContainerStats is deprecated: use [container.StatsResponseReader]. (staticcheck)
mock/docker/container.go|495 col 9| SA1019: types.ContainersPruneReport is deprecated: use [container.PruneReport]. (staticcheck)
mock/docker/container.go|503 col 9| SA1019: types.ContainerStats is deprecated: use [container.StatsResponseReader]. (staticcheck)
mock/docker/container.go|511 col 14| SA1019: types.ContainerPathStat is deprecated: use [container.PathStat]. (staticcheck)
mock/docker/network.go|40 col 10| SA1019: types.NetworkCreateResponse is deprecated: use [network.CreateResponse]. (staticcheck)
mock/docker/network.go|47 col 10| SA1019: types.NetworkCreateResponse is deprecated: use [network.CreateResponse]. (staticcheck)
mock/docker/network.go|56 col 10| SA1019: types.NetworkCreateResponse is deprecated: use [network.CreateResponse]. (staticcheck)
mock/docker/network.go|84 col 10| SA1019: types.NetworkResource is deprecated: use [network.Inspect] or [network.Summary] (for list operations). (staticcheck)
mock/docker/network.go|89 col 10| SA1019: types.NetworkResource is deprecated: use [network.Inspect] or [network.Summary] (for list operations). (staticcheck)
mock/docker/network.go|96 col 10| SA1019: types.NetworkResource is deprecated: use [network.Inspect] or [network.Summary] (for list operations). (staticcheck)
mock/docker/network.go|176 col 9| SA1019: types.NetworksPruneReport is deprecated: use [network.PruneReport]. (staticcheck)
mock/docker/volume.go|173 col 9| SA1019: types.VolumesPruneReport is deprecated: use [volume.PruneReport]. (staticcheck)
runtime/kubernetes/mock.go|143 col 53| Error return value of (k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler
is not checked (errcheck)
runtime/kubernetes/pod_tracker.go|226 col 40| Error return value of (k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler
is not checked (errcheck)
runtime/kubernetes/pod_tracker_test.go|184 col 25| unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
runtime/kubernetes/pod_tracker_test.go|373 col 4| expressions should not be cuddled with blocks (wsl)
cmd/vela-worker/exec.go|31 col 1| cyclomatic complexity 31 of func (*Worker).exec
is high (> 30) (gocyclo)
cmd/vela-worker/start.go|50 col 4| assignments should only be cuddled with other assignments (wsl)
cmd/vela-worker/start.go|54 col 4| expressions should not be cuddled with blocks (wsl)
cmd/vela-worker/start.go|57 col 4| assignments should only be cuddled with other assignments (wsl)
cmd/vela-worker/start.go|61 col 4| return statements should not be cuddled if block has more than two lines (wsl)
cmd/vela-worker/start.go|70 col 3| expressions should not be cuddled with declarations or returns (wsl)
cmd/vela-worker/exec.go|30 col 1| directive //nolint:nilerr,funlen // ignore returning nil - don't want to crash worker
is unused for linter "nilerr" (nolintlint)
Filtered Findings (0)
Annotations
Check failure on line 138 in internal/service/snapshot_test.go
github-actions / golangci
[golangci] internal/service/snapshot_test.go#L138
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
Raw output
internal/service/snapshot_test.go:138:25: unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
t.Run(test.name, func(t *testing.T) {
^
Check failure on line 166 in internal/service/upload_test.go
github-actions / golangci
[golangci] internal/service/upload_test.go#L166
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
Raw output
internal/service/upload_test.go:166:25: unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
t.Run(test.name, func(t *testing.T) {
^
Check failure on line 38 in mock/worker/executor.go
github-actions / golangci
[golangci] mock/worker/executor.go#L38
SA1019: library.Executor is deprecated: use Executor from github.com/go-vela/server/api/types instead. (staticcheck)
Raw output
mock/worker/executor.go:38:13: SA1019: library.Executor is deprecated: use Executor from github.com/go-vela/server/api/types instead. (staticcheck)
var body []library.Executor
^
Check failure on line 58 in mock/worker/executor.go
github-actions / golangci
[golangci] mock/worker/executor.go#L58
SA1019: library.Executor is deprecated: use Executor from github.com/go-vela/server/api/types instead. (staticcheck)
Raw output
mock/worker/executor.go:58:11: SA1019: library.Executor is deprecated: use Executor from github.com/go-vela/server/api/types instead. (staticcheck)
var body library.Executor
^
Check failure on line 46 in executor/local/step.go
github-actions / golangci
[golangci] executor/local/step.go#L46
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
Raw output
executor/local/step.go:46:27: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
func (c *client) PlanStep(ctx context.Context, ctn *pipeline.Container) error {
^
Check failure on line 49 in executor/local/service.go
github-actions / golangci
[golangci] executor/local/service.go#L49
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
Raw output
executor/local/service.go:49:30: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
func (c *client) PlanService(ctx context.Context, ctn *pipeline.Container) error {
^
Check failure on line 426 in executor/local/build_test.go
github-actions / golangci
[golangci] executor/local/build_test.go#L426
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
Raw output
executor/local/build_test.go:426:22: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
planNothing := func(ctx context.Context, container *pipeline.Container) error {
^
Check failure on line 470 in executor/local/build_test.go
github-actions / golangci
[golangci] executor/local/build_test.go#L470
unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
Raw output
executor/local/build_test.go:470:19: unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
planFunc: func(c *client) planFuncType {
^
Check failure on line 515 in executor/local/build_test.go
github-actions / golangci
[golangci] executor/local/build_test.go#L515
unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
Raw output
executor/local/build_test.go:515:19: unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
planFunc: func(c *client) planFuncType {
^
Check failure on line 303 in runtime/docker/container.go
github-actions / golangci
[golangci] runtime/docker/container.go#L303
SA1019: types.ExecConfig is deprecated: use [container.ExecOptions]. (staticcheck)
Raw output
runtime/docker/container.go:303:16: SA1019: types.ExecConfig is deprecated: use [container.ExecOptions]. (staticcheck)
execConfig := types.ExecConfig{
^
Check failure on line 315 in runtime/docker/container.go
github-actions / golangci
[golangci] runtime/docker/container.go#L315
SA1019: types.ExecStartCheck is deprecated: use [container.ExecStartOptions] or [container.ExecAttachOptions]. (staticcheck)
Raw output
runtime/docker/container.go:315:78: SA1019: types.ExecStartCheck is deprecated: use [container.ExecStartOptions] or [container.ExecAttachOptions]. (staticcheck)
hijackedResponse, err := c.Docker.ContainerExecAttach(ctx, responseExec.ID, types.ExecStartCheck{})
^
Check failure on line 23 in runtime/docker/network.go
github-actions / golangci
[golangci] runtime/docker/network.go#L23
SA1019: types.NetworkCreate is deprecated: use [network.CreateOptions]. (staticcheck)
Raw output
runtime/docker/network.go:23:10: SA1019: types.NetworkCreate is deprecated: use [network.CreateOptions]. (staticcheck)
opts := types.NetworkCreate{
^
Check failure on line 45 in runtime/docker/network.go
github-actions / golangci
[golangci] runtime/docker/network.go#L45
SA1019: types.NetworkInspectOptions is deprecated: use [network.InspectOptions]. (staticcheck)
Raw output
runtime/docker/network.go:45:10: SA1019: types.NetworkInspectOptions is deprecated: use [network.InspectOptions]. (staticcheck)
opts := types.NetworkInspectOptions{}
^
Check failure on line 1100 in executor/linux/build_test.go
github-actions / golangci
[golangci] executor/linux/build_test.go#L1100
unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
Raw output
executor/linux/build_test.go:1100:19: unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
planFunc: func(c *client) planFuncType {
^
Check failure on line 209 in executor/linux/secret.go
github-actions / golangci
[golangci] executor/linux/secret.go#L209
non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
Raw output
executor/linux/secret.go:209:37: non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
return nil, fmt.Errorf("%s: %w", ErrUnableToRetrieve, err)
^
Check failure on line 226 in executor/linux/secret.go
github-actions / golangci
[golangci] executor/linux/secret.go#L226
non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
Raw output
executor/linux/secret.go:226:37: non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
return nil, fmt.Errorf("%s: %w", ErrUnableToRetrieve, err)
^
Check failure on line 243 in executor/linux/secret.go
github-actions / golangci
[golangci] executor/linux/secret.go#L243
non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
Raw output
executor/linux/secret.go:243:37: non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
return nil, fmt.Errorf("%s: %w", ErrUnableToRetrieve, err)
^
Check failure on line 1549 in executor/linux/build_test.go
github-actions / golangci
[golangci] executor/linux/build_test.go#L1549
if statements should only be cuddled with assignments (wsl)
Raw output
executor/linux/build_test.go:1549:5: if statements should only be cuddled with assignments (wsl)
if test.earlyExecExit {
^
Check failure on line 987 in executor/linux/build_test.go
github-actions / golangci
[golangci] executor/linux/build_test.go#L987
if statements should only be cuddled with assignments used in the if statement itself (wsl)
Raw output
executor/linux/build_test.go:987:6: if statements should only be cuddled with assignments used in the if statement itself (wsl)
if !test.logError {
^
Check failure on line 863 in executor/linux/build_test.go
github-actions / golangci
[golangci] executor/linux/build_test.go#L863
only one cuddle assignment allowed before if statement (wsl)
Raw output
executor/linux/build_test.go:863:5: only one cuddle assignment allowed before if statement (wsl)
if err != nil {
^
Check failure on line 1605 in executor/linux/build_test.go
github-actions / golangci
[golangci] executor/linux/build_test.go#L1605
if statements should only be cuddled with assignments (wsl)
Raw output
executor/linux/build_test.go:1605:4: if statements should only be cuddled with assignments (wsl)
if test.logError && !loggedError {
^
Check failure on line 212 in executor/linux/build_test.go
github-actions / golangci
[golangci] executor/linux/build_test.go#L212
if statements should only be cuddled with assignments (wsl)
Raw output
executor/linux/build_test.go:212:4: if statements should only be cuddled with assignments (wsl)
if test.logError && !loggedError {
^
Check failure on line 322 in executor/linux/build_test.go
github-actions / golangci
[golangci] executor/linux/build_test.go#L322
defer statements should only be cuddled with expressions on same variable (wsl)
Raw output
executor/linux/build_test.go:322:4: defer statements should only be cuddled with expressions on same variable (wsl)
defer loggerHook.Reset()
^
Check failure on line 384 in executor/linux/build_test.go
github-actions / golangci
[golangci] executor/linux/build_test.go#L384
ranges should only be cuddled with assignments used in the iteration (wsl)
Raw output
executor/linux/build_test.go:384:4: ranges should only be cuddled with assignments used in the iteration (wsl)
for _, logEntry := range loggerHook.AllEntries() {
^
Check failure on line 697 in executor/linux/build_test.go
github-actions / golangci
[golangci] executor/linux/build_test.go#L697
if statements should only be cuddled with assignments used in the if statement itself (wsl)
Raw output
executor/linux/build_test.go:697:6: if statements should only be cuddled with assignments used in the if statement itself (wsl)
if !test.logError {
^