enhance(exec): pop from channels specified in worker DB record #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #504 +/- ##
=======================================
Coverage 83.42% 83.42%
=======================================
Files 69 69
Lines 5376 5376
=======================================
Hits 4485 4485
Misses 746 746
Partials 145 145 |
timhuynh94
approved these changes
Aug 31, 2023
wass3rw3rk
reviewed
Aug 31, 2023
No, it'll get the new routes before popping the next build |
|
yup.. nevermind 👍🏼 |
wass3r
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conclusion of go-vela/server#948, which allowed popping of specified channels.
This small change allows platform admins to adjust the queue routes of any worker without restarting