Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APIv1: Accounts #657

Open
fmartingr opened this issue Jul 21, 2023 · 0 comments · May be fixed by #825
Open

APIv1: Accounts #657

fmartingr opened this issue Jul 21, 2023 · 0 comments · May be fixed by #825
Assignees
@fmartingr
Labels
component:backend component:frontend The bug is in front-end database type:enhancement New feature or request
Milestone
1.8.0

Comments

@fmartingr
Copy link
Member

fmartingr commented Jul 21, 2023 •
edited
Loading

Migrate the legacy accounts API to the new router and API specification

Acceptance criteria

  • /api/v1/accounts: GET for list, POST for creation.
  • /api/v1/accounts/:id: PUT/PATCH for modification, GET for retrieving information, DELETE for deletion.
  • /api/v1/auth/account (replaces /api/v1/auth/me) allow GET to get currently logged in user information and PATCH to update own attributes (allow modifying only a subset of the user attributes).
  • Logic should be moved to domains
  • All endpoints should be properly tested.
  • All endpoints should use swagger definitions.
  • All endpoints require the user to be authenticated and be owner except /api/v1/auth/account which only affects the current logged in user.

Relates to: #640
FIxes: #613
@fmartingr fmartingr converted this from a draft issue Jul 21, 2023
@fmartingr fmartingr added this to the 1.6.1 milestone Jul 21, 2023
@fmartingr fmartingr added type:enhancement New feature or request component:frontend The bug is in front-end component:backend database labels Jul 21, 2023
@fmartingr fmartingr self-assigned this Jul 21, 2023
@fmartingr fmartingr removed their assignment Sep 12, 2023
@fmartingr fmartingr mentioned this issue Dec 10, 2023
Open
@fmartingr fmartingr self-assigned this Jan 27, 2024
@fmartingr fmartingr moved this from To do to In progress in Roadmap Jan 27, 2024
@fmartingr fmartingr modified the milestones: 1.7.0, 1.8.0 Apr 27, 2024
@fmartingr fmartingr moved this from In progress to To do in Roadmap May 6, 2024
@fmartingr fmartingr modified the milestones: 1.8.0, 1.7.0 Jun 5, 2024
@fmartingr fmartingr moved this from To do to In progress in Roadmap Jun 5, 2024
@fmartingr fmartingr linked a pull request Jun 5, 2024 that will close this issue
Open
fmartingr added a commit that referenced this issue Jun 8, 2024
@fmartingr
APIv1: Accounts
eaf10f2 
Fixes #657
@fmartingr fmartingr moved this from In progress to To do in Roadmap Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fmartingr fmartingr

Labels
component:backend component:frontend The bug is in front-end database type:enhancement New feature or request
Projects
Roadmap
Status: To do
Milestone
1.8.0
Development

Successfully merging a pull request may close this issue.

refactor(apiv1): accounts api go-shiori/shiori
1 participant
@fmartingr