Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There appears to be confusion over int32 and uint32 #9

Open
jaybinks opened this issue Mar 6, 2023 · 0 comments
Open

There appears to be confusion over int32 and uint32 #9

jaybinks opened this issue Mar 6, 2023 · 0 comments

Comments

@jaybinks
Copy link

jaybinks commented Mar 6, 2023

chromaprint_get_raw_fingerprint appears to return a pointer to uint32 , but in chromaprint.go GetRawFingerprint() this is converted to a []int32 with goInt32s

I would imagine for this to be safe you would want to use []int64 to avoid overflows OR we might need to be using uint32[]

Am I missing something here?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jaybinks