Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor HashSet to be a blume filter to avoid the set growing indefinitely #210

Open
ryardley opened this issue Dec 22, 2024 · 0 comments
Open

Refactor HashSet to be a blume filter to avoid the set growing indefinitely #210

ryardley opened this issue Dec 22, 2024 · 0 comments
Labels
bug Something isn't working Ciphernode Related to the ciphernode package technical debt Unaddressed shortcuts thay will become expensive problems later.

Comments

@ryardley
Copy link
Contributor 

          _:hammer_and_wrench: Refactor suggestion_

Limit the scope of your HashSet
'sent_events' grows indefinitely. Consider pruning older events or using a rolling cache to avoid unbounded growth in long-running processes.

Originally posted by @coderabbitai[bot] in #205 (comment)
@ryardley ryardley added bug Something isn't working Ciphernode Related to the ciphernode package technical debt Unaddressed shortcuts thay will become expensive problems later. labels Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Ciphernode Related to the ciphernode package technical debt Unaddressed shortcuts thay will become expensive problems later.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ryardley