Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up error handling #138

Open
ryardley opened this issue Oct 4, 2024 · 1 comment
Open

Tidy up error handling #138

ryardley opened this issue Oct 4, 2024 · 1 comment
Labels
bug Something isn't working Ciphernode Related to the ciphernode package

Comments

@ryardley
Copy link
Contributor

ryardley commented Oct 4, 2024

Sweep codebase for unwrap / Result<T> ensure errors are being passed to eventbus for logging with adequate context. Could possibly make a second channel for errors but it is not required as errors are not propagated onwards.

@ryardley ryardley added bug Something isn't working Ciphernode Related to the ciphernode package labels Oct 8, 2024
@ryardley
Copy link
Contributor Author

ryardley commented Oct 15, 2024

If an easy lift ensure we have better error handing especially around external dependencies.

Will put this in a separate ticket but it would be really great if this could decode the EVM error if possible.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Ciphernode Related to the ciphernode package
Projects
None yet
Development

No branches or pull requests

1 participant