-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fs2.data.xml.XmlException: character 'ʿ' cannot start a NCName
#337
Comments
Adding Scalacheck-based tests as proposed in scala/scala-xml#606 would help catch these in fs2-data itself. |
I fear this is a limitation of the current character enumeration method. I need to dig deeper. |
After investigating more I understood what the problem is. The fs2-data XML parser uses XML namespace, which restricts the range of valid element identifier.
I might change this, to make it optional through an option (NCName parsing or not). Would that be acceptable to you? |
It looks I was referring to an obsolete version of names, I need to change it, actually… |
Glad you figured it out. I have no clue about this stuff, just reporting the discrepancy I discovered. Appreciate your work!! |
Btw Ross ended up publishing scalacheck instances for scala-xml: |
Previous version was based on an obsolete definition of what valid characters can appear in names. The new ones maps with the character ranges described in the latest version of the specification. Ranges are represented as a specialized minimal implementation of a Discrete Interval Encoding Tree. Fixes #337
Previous version was based on an obsolete definition of what valid characters can appear in names. The new ones maps with the character ranges described in the latest version of the specification. Ranges are represented as a specialized minimal implementation of a Discrete Interval Encoding Tree. Fixes #337
Via http4s/http4s-scala-xml#25 (comment).
The text was updated successfully, but these errors were encountered: